Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional config object for topic, auth, storage, leaderboard clients #1442

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat: optional config object for topic, auth, storage, leaderboard clients #1442

merged 1 commit into from
Oct 7, 2024

Conversation

anitarua
Copy link
Contributor

@anitarua anitarua commented Oct 4, 2024 •
edited
Loading

Work towards https://github.com/momentohq/dev-eco-issue-tracker/issues/1035

Only the CacheClient requires a config value for default TTL. All other clients have optional config options, so the entire config object can be made optional.

const topicClient = new TopicClient();

// instead of 

const topicClient = new TopicClient({});

Will follow up with updates to docs/examples

@anitarua anitarua marked this pull request as ready for review October 4, 2024 19:33
@anitarua anitarua requested a review from a team October 4, 2024 19:34
@anitarua anitarua merged commit 411a7a8 into main Oct 7, 2024
13 checks passed
@anitarua anitarua deleted the optional-configs branch October 7, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malandis malandis malandis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @malandis